Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): SettingsSidebar should disconnect from push when navigating away #6025

Merged
merged 3 commits into from
Apr 20, 2023
Merged

fix(editor): SettingsSidebar should disconnect from push when navigating away #6025

merged 3 commits into from
Apr 20, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Apr 20, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

4 similar comments
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 20, 2023
@netroy netroy requested a review from mutdmour April 20, 2023 09:34
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c3d19f5) 18.67% compared to head (c581c2b) 18.67%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6025   +/-   ##
=======================================
  Coverage   18.67%   18.67%           
=======================================
  Files        2582     2582           
  Lines      116476   116476           
  Branches    18177    18177           
=======================================
  Hits        21752    21752           
  Misses      94086    94086           
  Partials      638      638

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit 41660d9 into master Apr 20, 2023
@netroy netroy deleted the PAY-405-close-SSE branch April 20, 2023 10:23
netroy added a commit that referenced this pull request Apr 20, 2023
@netroy
fix(editor): SettingsSidebar should disconnect from push when navigat…
b475c8f 
…ing away (#6025)
netroy added a commit that referenced this pull request Apr 20, 2023
@netroy
fix(editor): SettingsSidebar should disconnect from push when navigat…
e9f8cfe 
…ing away (#6025)
@janober
Copy link
Member

janober commented Apr 20, 2023

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request Apr 21, 2023
@MiloradFilipovic
Merge branch 'master' into N8N-5677-refactor-workflows-store
f2c5398 
* master: (199 commits)
  feat(editor): Add disable template experiment (#5963)
  feat(core): Upgrade google-timezones-json to use the correct timezone for Sao Paulo (#6042)
  fix(Code Node): Update vm2 to address CVE-2023-30547 (#6039)
  docs: Add proprietary license text (no-changelog) (#6038)
  test(n8n Node): Unit tests (no-changelog)
  refactor: Accumulate `loadOptions` from all node versions to validate (no-changelog) (#6014)
  Update CHANGELOG.md
  feat: Add variables e2e tests (no-changelog) (#6027)
  fix(editor): Fix typo in SSO upgrade link (#6031)
  fix(editor): Add correct add variable button message when no variables created (no-changelog) (#6028)
  docs: Add api notice to credentials for google sheets nodes (no-changelog) (#6024)
  fix(Notion Node): Update credential test to not require user permissions (#6022)
  fix(editor): Clean up demo and template callouts from workflows page (#6023)
  fix(editor): Fix memory leak in Node Detail View by correctly unsubscribing from event buses (#6021)
  fix(editor): SettingsSidebar should disconnect from push when navigating away (#6025)
  fix(editor): Use fake timers in useDebounce.test.ts to make the test less flaky (no-changelog) (#6029)
  docs: Update the info URL for updating n8n (no-changelog) (#6018)
  fix(core): Improve domain and url matching for extractDomain and extractUrl (#6010)
  feat(core): Add SSH key generation (#6006)
  fix(editor): Update SSO upgrade link (#6016)
  ...

# Conflicts:
#	packages/editor-ui/src/components/WorkflowShareModal.ee.vue
#	packages/editor-ui/src/stores/workflows.ts
#	packages/editor-ui/src/views/NodeView.vue
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@netroy @sunilrr
fix(editor): SettingsSidebar should disconnect from push when navigat…
5d0c920 
…ing away (n8n-io#6025)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @mutdmour